linux-kernel - RE: regulator: fan53555: vsel_max does not match with the max voltage?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4737A960563B524DA805CA602BE04B3064CC59077C@SC-VEXCH2.marvell.com>
Date:	Sun, 9 Sep 2012 20:17:55 -0700
From:	Yunfan Zhang <yfzhang@...vell.com>
To:	Axel Lin <axel.lin@...il.com>
CC:	Liam Girdwood <lrg@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: regulator: fan53555: vsel_max does not match with the max
 voltage?

> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@...il.com]
> Sent: 2012年9月10日 11:05
> To: Yunfan Zhang
> Cc: Liam Girdwood; Mark Brown; linux-kernel@...r.kernel.org
> Subject: regulator: fan53555: vsel_max does not match with the max voltage?
> 
> Hi Yunfan,
> Just found below issue while reading the code:
> 
> For FAN53555_CHIP_ID_04,
>         di->vsel_min = 603000;
>         di->vsel_max = 1411000;
>         di->vsel_step = 12826;
> volt[63] = 1411038
> 
> Then volt[63] is greater than the vsel_max now.
> This looks does not make sense.

Axel, Thanks for your findings! 
Yes, the volt[63] is GT the vsel_max. Actually vsel_max is not used... The max voltage will be bounded by desc->n_voltages. I will make a patch to remove it to avoid confusing. Thanks a lot!