linux-kernel - Re: [PATCH] leds: add led_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Sep 2012 19:57:25 +0200
From:	Fabio Baltieri <fabio.baltieri@...il.com>
To:	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
	Richard Purdie <rpurdie@...ys.net>,
	Bryan Wu <bryan.wu@...onical.com>
Subject: Re: [PATCH] leds: add led_trigger_rename function

On Mon, Sep 10, 2012 at 03:55:35PM +0200, Kurt Van Dijck wrote:
> On Sun, Sep 09, 2012 at 05:27:54PM +0200, Fabio Baltieri wrote:
> > Implements a led_trigger_rename() function to rename a trigger with
> > proper locking.
> This is the way to go.
> Maybe add 'default_trigger' tests? In a later phase?

Do you think that default_trigger should be processed on renames?  I
usually think of default_trigger as something just on boot time, but
that could make sense after all.

I think that could go for later phase anyway.

> > This also implies that "name" in "struct led_trigger" is not const
> > anymore.
> IMHO, this is wrong. This forces all other led_triggers
> to put their name in non-const storage.

Uh - is that really a problem?

Fabio

-- 
Fabio Baltieri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/