linux-kernel - Re: [char-misc-next 2/3] mei: struct mei_message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120911002449.3aa7728a@pyramind.ukuu.org.uk>
Date:	Tue, 11 Sep 2012 00:24:49 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	gregkh@...uxfoundation.org, arnd@...db.de, alan@...ux.intel.com,
	linux-kernel@...r.kernel.org
Subject: Re: [char-misc-next 2/3] mei: struct mei_message_data doesn't have
 to be packed

On Tue, 11 Sep 2012 00:43:21 +0300
Tomas Winkler <tomas.winkler@...el.com> wrote:

> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> ---
>  drivers/misc/mei/mei_dev.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/mei/mei_dev.h b/drivers/misc/mei/mei_dev.h
> index 96d3e79..adb35fb 100644
> --- a/drivers/misc/mei/mei_dev.h
> +++ b/drivers/misc/mei/mei_dev.h
> @@ -140,7 +140,7 @@ enum mei_cb_major_types {
>  struct mei_message_data {
>  	u32 size;
>  	unsigned char *data;
> -} __packed;
> +};

Explanation would be useful especially for this one. The others are
obvious although a one line comment would still be good form perhaps.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/