linux-kernel - Re: [PATCH] allow gpiolib to be a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504ED77D.90008@gmail.com>
Date:	Tue, 11 Sep 2012 16:17:33 +1000
From:	Ryan Mallon <rmallon@...il.com>
To:	Jan Beulich <JBeulich@...e.com>
CC:	linus.walleij@...aro.org, grant.likely@...retlab.ca,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] allow gpiolib to be a module

On 10/09/12 22:16, Jan Beulich wrote:
> Without ARCH_REQUIRE_GPIOLIB there's no reason to force this code, when
> enabled, to always be built into the kernel, which requires only minor
> Makefile and source code adjustments.
> 
> Signed-off-by: Jan Beulich <jbeulich@...e.com>
> 
> ---

<snip>

> +#ifdef MODULE
> +int __init gpiolib_init(void)

Should be static.

> +{
> +	return gpiolib_sysfs_init() ?: gpiolib_debugfs_init();

I thought this was going to call gpiolib_sysfs_init() twice until I
looked at gcc's documentation. Maybe the less obtuse, and far more common:

  int err;

  err = gpiolib_sysfs_init();
  if (err)
          return err;

  return gpiolib_debugfs_init();

?

> +}
> +module_init(gpiolib_init);

~Ryan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/