linux-kernel - Re: [PATCH] PCI: drop duplicate const in DECLARE_PCI_FIXUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAErSpo7-c+UTnjQHuvF1H7CizH=aN5FBGcG95RMZj4mjUggTUQ@mail.gmail.com>
Date:	Mon, 10 Sep 2012 18:07:40 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Mathias Krause <minipli@...glemail.com>
Cc:	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: drop duplicate const in DECLARE_PCI_FIXUP_SECTION

On Sun, Sep 9, 2012 at 10:54 AM, Mathias Krause <minipli@...glemail.com> wrote:
> On Sun, Sep 2, 2012 at 11:37 PM, Mathias Krause <minipli@...glemail.com> wrote:
>> It's redundant and makes sparse complain about it.
>>
>> Signed-off-by: Mathias Krause <minipli@...glemail.com>
>> ---
>>  include/linux/pci.h |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/pci.h b/include/linux/pci.h
>> index 5faa831..aee24a8 100644
>> --- a/include/linux/pci.h
>> +++ b/include/linux/pci.h
>> @@ -1472,7 +1472,7 @@ enum pci_fixup_pass {
>>  /* Anonymous variables would be nice... */
>>  #define DECLARE_PCI_FIXUP_SECTION(section, name, vendor, device, class,        \
>>                                   class_shift, hook)                    \
>> -       static const struct pci_fixup const __pci_fixup_##name __used   \
>> +       static const struct pci_fixup __pci_fixup_##name __used         \
>>         __attribute__((__section__(#section), aligned((sizeof(void *)))))    \
>>                 = { vendor, device, class, class_shift, hook };
>>
>> --
>> 1.7.10.4
>>
>
> Ping? It's janitor work, but hey, it fixes a sparse warning.

Yep, it's worth doing; I'm just slow.  I applied it to my
"pci/trivial" branch.  Thanks!

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/