linux-kernel - Re: [PATCH v2] x86/mce: Honour bios-set CMCI threshold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+8MBbKVa0=qUpG-rjV5ieKkponZo77mzk_y_dF4qA2gVG++6A@mail.gmail.com>
Date:	Tue, 11 Sep 2012 09:04:37 -0700
From:	Tony Luck <tony.luck@...el.com>
To:	"Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
Cc:	andi@...stfloor.org, bp@...64.org, gong.chen@...ux.intel.com,
	ananth@...ibm.com, masbock@...ux.vnet.ibm.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, lcm@...ibm.com, mingo@...hat.com,
	hpa@...or.com, tglx@...utronix.de, gregkh@...e.de,
	linux-edac@...r.kernel.org
Subject: Re: [PATCH v2] x86/mce: Honour bios-set CMCI threshold

On Mon, Sep 10, 2012 at 10:31 PM, Naveen N. Rao
<naveen.n.rao@...ux.vnet.ibm.com> wrote:
> +       if (mce_bios_cmci_threshold)
> +               printk_once(KERN_INFO
> +                       "bios_cmci_threshold: Using bios-set threshold values for CMCI");

Do we really need this message? The user knows whether they gave
the command line option or not (and can check in /proc/cmdline if
they forgot whether they did). If it is needed, then you should add
a "\n" to it.

> +       if (mce_bios_cmci_threshold && bios_wrong_thresh) {
> +               printk_once(KERN_INFO
> +                       "bios_cmci_threshold: Some banks do not have valid thresholds set");
> +               printk_once(KERN_INFO
> +                       "bios_cmci_threshold: Make sure your BIOS supports this boot option");

Also need "\n"

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/