linux-kernel - Re: [PATCH 09/16] ARM: tegra: move platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Sep 2012 13:11:55 -0400
From:	Chris Ball <cjb@...top.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	Colin Cross <ccross@...roid.com>,
	Olof Johansson <olof@...om.net>,
	Stephen Warren <swarren@...dotorg.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Liam Girdwood <lrg@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH 09/16] ARM: tegra: move platform_data definitions

Hi,

On Tue, Sep 11 2012, Arnd Bergmann wrote:
>> Looks like you aren't renaming the idempotency guards, so e.g.
>> include/linux/platform_data/mmc-sdhci-tegra.h will contain:
>> 
>> #ifndef __ASM_ARM_ARCH_TEGRA_SDHCI_H
>> #define __ASM_ARM_ARCH_TEGRA_SDHCI_H
>> 
>> Is that intentional?  Thanks,
>
> No, it's not intentional. We actually have a lot of instances that
> are already wrong. Do we care enough to change the ones I'm moving here?

It's clearly not a big deal.  I did fix it in Stephen's previous version
of this change, though.

Maybe just add a note to the commit message explaining that you aren't
changing the guards and driver maintainers might want to fix them up if
it's something they care about?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@...top.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/