linux-kernel - Re: [PATCH] Staging: comedi: drivers: fl512: change printk(KERN_INFO ... for the prefered pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120911025252.GA28112@kroah.com>
Date:	Mon, 10 Sep 2012 19:52:52 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Bruce Humphrey <brucehum@...il.com>
Cc:	abbotti@....co.uk, fmhess@...rs.sourceforge.net,
	hsweeten@...ionengravers.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: drivers: fl512: change printk(KERN_INFO
 ... for the prefered pr_info(...

On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the prefered pr_info, pr_warn and pr_error
> 
> Signed-off-by: Bruce Humphrey Ventura <brucehum@...il.com>
> ---
>  drivers/staging/comedi/drivers/fl512.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
> index d1da809..258a7b4 100644
> --- a/drivers/staging/comedi/drivers/fl512.c
> +++ b/drivers/staging/comedi/drivers/fl512.c
> @@ -118,9 +118,9 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  	struct comedi_subdevice *s;
>  
>  	iobase = it->options[0];
> -	printk(KERN_INFO "comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> +	pr_info("comedi:%d fl512: 0x%04lx", dev->minor, iobase);

Why can't you use dev_info() here, and in other places?  You should use
the dev_* functions instead of pr_* wherever possible.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/