linux-kernel - Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node and online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Sep 2012 11:09:27 +0800
From:	Lai Jiangshan <laijs@...fujitsu.com>
To:	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
CC:	Mel Gorman <mgorman@...e.de>, David Rientjes <rientjes@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	x86 maintainers <x86@...nel.org>,
	Jiang Liu <jiang.liu@...wei.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Yinghai Lu <yinghai@...nel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node
 and online_movable for hotplug

On 09/11/2012 09:37 AM, Yasuaki Ishimatsu wrote:
> Hi Lai,
> 
> 2012/09/11 10:22, Lai Jiangshan wrote:
>> On 09/11/2012 08:40 AM, Yasuaki Ishimatsu wrote:
>>> Hi Lai,
>>>
>>> Using memory_online to hot-added node's memory, the following kernel messages
>>> were shown. Is this a known issue?
>>
>> Thank you for your report.
>>
>> What operations did you have performed ?
> 
> My operations are as follows:
> 
> 1. Hot-add a new node by container driver.
>    In my system, container driver hot-addes a new nodes which includes CPUs and
>    memorys.
> 
> 2. echo online_movable to hot-added nodes's memory
>    When container driver hot-adds a new nodes, my system creates node2 sysfs.
>    And the sysfs has memory768-memory1023 sysfs. So I echo "online_movable"
>    to memory1023/state file.
>    # echo online_movable > memory1023/state
> 


I can't reproduce the bug. and my system is a little different from you.
could you show me the /proc/zoneinfo?

also, could you add following patch, it will help me know which constraint I have broken.

Thanks,
Lai

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 3878170..68302ef 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -549,6 +549,9 @@ static inline void __free_one_page(struct page *page,
 
 	page_idx = page_to_pfn(page) & ((1 << MAX_ORDER) - 1);
 
+	VM_BUG_ON(page_outside_zone_boundaries(zone, page));
+	VM_BUG_ON(!pfn_valid_within(page_to_pfn(page)));
+	VM_BUG_ON(zone != page_zone(page));
 	VM_BUG_ON(page_idx & ((1 << order) - 1));
 	VM_BUG_ON(bad_range(zone, page));
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/