lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 10 Sep 2012 20:44:57 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Bruce Humphrey <brucehum@...il.com>, abbotti@....co.uk,
	fmhess@...rs.sourceforge.net, hsweeten@...ionengravers.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: drivers: fl512: change printk(KERN_INFO
 ... for the prefered pr_info(...

On Mon, Sep 10, 2012 at 08:40:11PM -0700, Joe Perches wrote:
> On Mon, 2012-09-10 at 19:52 -0700, Greg KH wrote:
> > On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> > > Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the prefered pr_info, pr_warn and pr_error
> []
> > > diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
> []
> > > @@ -118,9 +118,9 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> []
> > > -	printk(KERN_INFO "comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> > > +	pr_info("comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> > 
> > Why can't you use dev_info() here, and in other places?  You should use
> > the dev_* functions instead of pr_* wherever possible.
> 
> Checkpatch instigates these conversions.

I know.

> Perhaps something like:

That looks like a good start, until someone tries to use netdev_* in a
random non-network driver :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists