| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAOTypNRQn+yTH8jkDf2u+DAV42HM-igrxS4JO2NLu2U2PgS_7Q@mail.gmail.com> Date: Wed, 12 Sep 2012 16:36:19 +0900 From: Toshiaki Yamane <yamanetoshi@...il.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: devel@...verdev.osuosl.org, Manohar Vanga <manohar.vanga@...il.com>, linux-kernel@...r.kernel.org, Martyn Welch <martyn.welch@...com>, Dan Carpenter <dan.carpenter@...cle.com> Subject: Re: [PATCH 1/2] staging/vme: Use pr_ printks in vme_user.c On Wed, Sep 12, 2012 at 4:08 AM, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote: > On Tue, Sep 11, 2012 at 04:16:14PM +0900, Toshiaki Yamane wrote: >> The below checkpatch warnings was fixed, >> >> -WARNING: Prefer pr_info(... to printk(KERN_INFO, ... >> -WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ... >> -WARNING: Prefer pr_err(... to printk(KERN_ERR, ... > > A lot of these can be using dev_* instead of the pr_* functions, right? > Please convert to using them wherever possible. > > Because of that, I can't take this patch, sorry. Care to redo it? Yes. Is this collect? I must use dev_* procedure when the following conditions are met: - If I have access to struct device object by the argument of the procedure - Except for the right: struct net_device, etc. Otherwise, I must use pr_* procedure. Regards, YAMANE Toshiaki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists