linux-kernel - Re: [PATCH 2/3] scsi: create an all-zero filter for scanners

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120912133613.1255aa52@pyramind.ukuu.org.uk>
Date:	Wed, 12 Sep 2012 13:36:13 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Jens Axboe <axboe@...nel.dk>,
	Ric Wheeler <rwheeler@...hat.com>, linux-iscsi@...r.kernel.org
Subject: Re: [PATCH 2/3] scsi: create an all-zero filter for scanners

On Wed, 12 Sep 2012 13:23:43 +0200
Paolo Bonzini <pbonzini@...hat.com> wrote:

> Using /dev/sg for scanners is blocked from unprivileged users.  Reimplement
> this using customizable command filters, so that the sysfs knobs will work
> in this case too.
> 
> Cc: linux-iscsi@...r.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
>  drivers/scsi/scsi_scan.c |    6 +++++-
>  drivers/scsi/sg.c        |    3 ---
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index 56a9379..d168c15 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -773,13 +773,17 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned char *inq_result,
>  	}
>  
>  	switch (sdev->type) {
> +	case TYPE_SCANNER:
> +		sdev->request_queue->cmd_filter =
> +			kzalloc(sizeof(struct blk_cmd_filter), GFP_KERNEL);
> +		/* fallthrough */

Is that really desireable in the kzalloc failing case ?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/