linux-kernel - Re: [PATCH] drivers/media: Removes useless kfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+MoWDptdWtAoMvrQ==YN-VA0z9DQPhh_gLkUwJKof-FNHA+zw@mail.gmail.com>
Date:	Wed, 12 Sep 2012 14:45:50 +0200
From:	Peter Senna Tschudin <peter.senna@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	kernel-janitors@...r.kernel.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/media: Removes useless kfree()

I'll split this patch in one patch for file and resend.

On Wed, Sep 12, 2012 at 10:06 AM, Dan Carpenter
<dan.carpenter@...cle.com> wrote:
> On Tue, Sep 11, 2012 at 08:00:32PM +0200, Peter Senna Tschudin wrote:
>> diff --git a/drivers/media/dvb-frontends/lg2160.c b/drivers/media/dvb-frontends/lg2160.c
>> index cc11260..748da5d 100644
>> --- a/drivers/media/dvb-frontends/lg2160.c
>> +++ b/drivers/media/dvb-frontends/lg2160.c
>> @@ -1451,7 +1451,6 @@ struct dvb_frontend *lg2160_attach(const struct lg2160_config *config,
>>       return &state->frontend;
>>  fail:
>>       lg_warn("unable to detect LG216x hardware\n");
>> -     kfree(state);
>>       return NULL;
>>  }
>
> I wish you had fixed this the same as the others and removed the
> goto.  Also the printk is redundant and wrong.  Remove it too.
>
> regards,
> dan carpenter
>



-- 
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/