linux-kernel - Re: [PATCH 16/18] perf evsel: Introduce perf_evsel_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120912134749.GB10019@ghostprotocols.net>
Date:	Wed, 12 Sep 2012 06:47:49 -0700
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 16/18] perf evsel: Introduce perf_evsel__{str,int}val
 methods

Em Wed, Sep 12, 2012 at 10:40:00AM +0900, Namhyung Kim escreveu:
> On Tue, 11 Sep 2012 20:53:08 -0300, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@...hat.com>
> >
> > Wrappers to the libtraceevent routines, so that we can further reduce
> > the surface contact perf builtins have with it.
> [snip]
> > +char *perf_evsel__strval(struct perf_evsel *evsel, struct perf_sample *sample,
> > +			 const char *name)
> > +{
> > +	struct format_field *field = pevent_find_field(evsel->tp_format, name);
> > +	int offset;
> > +
> > +        if (!field)
> > +                return NULL;
> 
> Whitespace problem?

Argh, if it is so, I have somehow unwired my git hook scripts, will
check.
 
> Btw, as a generic wrapper shouldn't it handle common fields also?  If
> you care about performance, how about switching the order of finding
> fields in question, i.e.:
> 
> 	struct format_field *field = pevent_find_field(evsel->tp_format, name);
> 
> 	if (!field) {
> 		field = pevent_find_common_field(evsel->tp_format, name);
> 		if (!field)
> 			return NULL;
> 	}

When I see the need for looking at those commom fields, and so far I saw
none since we have perf_sample already, I think I'll add a wrapper for
pevent_find_common_field. I.e. use the fact we know we want one of those
fields, the _any_ is just a distraction, I think.
 
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/