linux-kernel - Re: [PATCH v3] trace: Move trace event enable from fs_initcall to core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1347457954.10751.38.camel@gandalf.local.home>
Date:	Wed, 12 Sep 2012 09:52:34 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ezequiel Garcia <elezegarcia@...il.com>
Cc:	linux-kernel@...r.kernel.org, Pekka Enberg <penberg@...nel.org>,
	tim.bird@...sony.com, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v3] trace: Move trace event enable from fs_initcall to
 core_initcall

On Wed, 2012-09-12 at 09:29 -0300, Ezequiel Garcia wrote:
> Steven,
> 
> On Tue, Sep 11, 2012 at 9:34 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> ble(void)
> [...]
> >> +     /*
> >> +      * Early initialization already enabled ftrace event.
> >> +      * Now it's only necessary to create the event directory.
> >> +      */
> >>       for_each_event(call, __start_ftrace_events, __stop_ftrace_events) {
> >> -             __trace_add_event_call(*call, NULL, &ftrace_event_id_fops,
> >
> > Here, __trace_add_event_call() did the checks and did not create a
> > directory on raw_init() failure. But now there's no check, and we are
> > having events being created that should not be.
> >
> 
> I believe the problem is we're iterating through every event
> defined in __start_ftrace_events.
> We should iterate through the events added to the ftrace_events list.

Yeah, that sounds like a better solution. I can't at the moment think of
anything where that would break.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/