linux-kernel - Re: [PATCH v2 1/3] hrtimer: add hrtimer_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPqkBRiDjaCw9CEpWgjxeOu4ybgv=-ieRZwZLberiU9m9vHOg@mail.gmail.com>
Date:	Wed, 12 Sep 2012 16:51:23 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"Yan, Zheng" <zheng.z.yan@...el.com>,
	Robert Richter <robert.richter@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH v2 1/3] hrtimer: add hrtimer_init_cpu()

On Wed, Sep 12, 2012 at 4:49 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Wed, 2012-09-12 at 16:46 +0200, Stephane Eranian wrote:
>
>> I am fine with dropping this patch. I just found it odd there was a per-cpu
>> data reference embedded deep into the call. I wanted things to be more
>> explicit. I know it works without the proposed change.
>
> Ah the reason its there is to make sure the base pointer is a valid base
> pointer, this avoids an extra conditional in a number of places. Note
> that it uses raw_get_cpu_var(), so it doesn't even actually know which
> specific pointer goes in.
>
>
Ok, fine. Then let's drop this patch then.
Thanks for the explanations.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/