linux-kernel - Re: [PATCH 1/3] mm: thp: Fix the pmd_clear() arguments in pmdp_get_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120912153016.GS21579@dhcp22.suse.cz>
Date:	Wed, 12 Sep 2012 17:30:16 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	Will Deacon <will.deacon@....com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, akpm@...ux-foundation.org,
	Catalin Marinas <catalin.marinas@....com>,
	Arnd Bergmann <arnd@...db.de>,
	Steve Capper <steve.capper@....com>
Subject: Re: [PATCH 1/3] mm: thp: Fix the pmd_clear() arguments in
 pmdp_get_and_clear()

On Tue 11-09-12 17:47:14, Will Deacon wrote:
> From: Catalin Marinas <catalin.marinas@....com>
> 
> The CONFIG_TRANSPARENT_HUGEPAGE implementation of pmdp_get_and_clear()
> calls pmd_clear() with 3 arguments instead of 1.

only for !__HAVE_ARCH_PMDP_GET_AND_CLEAR which doesn't seem to happen
because x86 defines this and it uses pmd_update.

> 
> Cc: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Catalin Marinas <catalin.marinas@....com>
> Signed-off-by: Steve Capper <steve.capper@....com>
> Signed-off-by: Will Deacon <will.deacon@....com>

Other than that it looks good.
Reviewed-by: Michal Hocko <mhocko@...e.cz>

> ---
>  include/asm-generic/pgtable.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
> index ff4947b..f7e0206 100644
> --- a/include/asm-generic/pgtable.h
> +++ b/include/asm-generic/pgtable.h
> @@ -87,7 +87,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
>  				       pmd_t *pmdp)
>  {
>  	pmd_t pmd = *pmdp;
> -	pmd_clear(mm, address, pmdp);
> +	pmd_clear(pmdp);
>  	return pmd;
>  }
>  #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> -- 
> 1.7.4.1
> 

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/