linux-kernel - Re: [PATCH v2] lib: gcd: prevent possible div by 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120912121055.bd417043.akpm@linux-foundation.org>
Date:	Wed, 12 Sep 2012 12:10:55 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	dave@....org
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	lkml <linux-kernel@...r.kernel.org>, stable@...r.kernel.org
Subject: Re: [PATCH v2] lib: gcd: prevent possible div by 0

On Mon, 10 Sep 2012 16:35:19 +0200
Davidlohr Bueso <dave@....org> wrote:

> Account for all properties when a and/or b are 0:
> gcd(0, 0) = 0
> gcd(a, 0) = a
> gcd(0, b) = b
> 
> Cc: stable@...r.kernel.org

Why cc:stable?  If this patch fixes some known problem in the current
kernel then that really really should have been described in the
changelog.  Always.  Please.

> ...
> --- a/lib/gcd.c
> +++ b/lib/gcd.c
> @@ -9,6 +9,9 @@ unsigned long gcd(unsigned long a, unsigned long b)
>  
>  	if (a < b)
>  		swap(a, b);
> +
> +	if (!b)
> +		return a;
>  	while ((r = a % b) != 0) {
>  		a = b;
>  		b = r;
> -- 
> 1.7.9.5
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/