linux-kernel - Re: [PATCH v2] pinctrl: pinctrl-single: Add pinctrl-single,bits type of mux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120912202700.GD5997@atomide.com>
Date:	Wed, 12 Sep 2012 13:27:01 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl: pinctrl-single: Add pinctrl-single,bits
 type of mux

* Peter Ujfalusi <peter.ujfalusi@...com> [120911 01:54]:
> With pinctrl-single,bits it is possible to update just part of the register
> within the pinctrl-single,function-mask area.
> This is useful when one register configures mmore than one pin's mux.

>  	size /= sizeof(*mux);	/* Number of elements in array */
> -	rows = size / 2;	/* Each row is a key value pair */
> +	rows = size / params;	/* Each row is a key value pair */

Maybe just remove the comment:  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I don't think it's needed any longer. Other than that,
thanks for updating the patch:

Acked-by: Tony Lindgren <tony@...mide.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/