linux-kernel - [PATCH 2/2] Staging: comedi: fl512: Replace printk with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Sep 2012 03:46:36 +0200
From:	Bruce Humphrey <brucehum@...il.com>
To:	abbotti@....co.uk, fmhess@...rs.sourceforge.net,
	gregkh@...uxfoundation.org
Cc:	hsweeten@...ionengravers.com, standby24x7@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Bruce Humphrey <brucehum@...il.com>
Subject: [PATCH 2/2] Staging: comedi: fl512: Replace printk with dev_info et al

Replace printk(KERN_XXX with the appropiate dev_info, dev_warn, dev_dbg in fl512.c

Signed-off-by: Bruce Humphrey Ventura <brucehum@...il.com>
---
 drivers/staging/comedi/drivers/fl512.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
index d1da809..5a8e0ae 100644
--- a/drivers/staging/comedi/drivers/fl512.c
+++ b/drivers/staging/comedi/drivers/fl512.c
@@ -118,9 +118,9 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 	struct comedi_subdevice *s;
 
 	iobase = it->options[0];
-	printk(KERN_INFO "comedi:%d fl512: 0x%04lx", dev->minor, iobase);
+	dev_info(dev->class_dev, "%s: 0x%04lx\n", dev->board_name, iobase);
 	if (!request_region(iobase, FL512_SIZE, "fl512")) {
-		printk(KERN_WARNING " I/O port conflict\n");
+		dev_warn(dev->class_dev, " I/O port conflict\n");
 		return -EIO;
 	}
 	dev->iobase = iobase;
@@ -129,7 +129,7 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 		return -ENOMEM;
 
 #if DEBUG
-	printk(KERN_DEBUG "malloc ok\n");
+	dev_dbg(dev->class_dev, "malloc ok\n");
 #endif
 
 	ret = comedi_alloc_subdevices(dev, 2);
@@ -153,7 +153,8 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 	s->range_table = &range_fl512;
 	/* function to call when read AD */
 	s->insn_read = fl512_ai_insn;
-	printk(KERN_INFO "comedi: fl512: subdevice 0 initialized\n");
+	dev_info(dev->class_dev, "%s: subdevice 0 initialized\n",
+		dev->board_name);
 
 	/* Analog output */
 	s = dev->subdevices + 1;
@@ -171,7 +172,8 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 	s->insn_write = fl512_ao_insn;
 	/* function to call when reading DA */
 	s->insn_read = fl512_ao_insn_readback;
-	printk(KERN_INFO "comedi: fl512: subdevice 1 initialized\n");
+	dev_info(dev->class_dev, "%s: subdevice 1 initialized\n",
+		dev->board_name);
 
 	return 1;
 }
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/