| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <50518CF8.2050106@ti.com> Date: Thu, 13 Sep 2012 10:36:24 +0300 From: Peter Ujfalusi <peter.ujfalusi@...com> To: Linus Walleij <linus.walleij@...aro.org> CC: Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] pinctrl: pinctrl-single: Add pinctrl-single,bits type of mux On 09/13/2012 09:52 AM, Linus Walleij wrote: > On Wed, Sep 12, 2012 at 10:27 PM, Tony Lindgren <tony@...mide.com> wrote: >> * Peter Ujfalusi <peter.ujfalusi@...com> [120911 01:54]: >>> With pinctrl-single,bits it is possible to update just part of the register >>> within the pinctrl-single,function-mask area. >>> This is useful when one register configures mmore than one pin's mux. >> >>> size /= sizeof(*mux); /* Number of elements in array */ >>> - rows = size / 2; /* Each row is a key value pair */ >>> + rows = size / params; /* Each row is a key value pair */ >> >> Maybe just remove the comment: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> I don't think it's needed any longer. Other than that, >> thanks for updating the patch: >> >> Acked-by: Tony Lindgren <tony@...mide.com> > > Applied minus the comment, plus Tony's ACK, thanks! Thank you Linus, I was about to send the v3 with the removed comment. -- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists