linux-kernel - Re: [PATCH -next] thermal: cpu_cooling.c needs to select CPU_FREQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Sep 2012 11:03:10 +0200
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Amit Kachhap <amit.kachhap@...aro.org>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Len Brown <lenb@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] thermal: cpu_cooling.c needs to select CPU_FREQ_TABLE

On Thu, Sep 13, 2012 at 10:46 AM, Amit Kachhap <amit.kachhap@...aro.org> wrote:
> On 13 September 2012 03:06, Randy Dunlap <rdunlap@...otime.net> wrote:
>> From: Randy Dunlap <rdunlap@...otime.net>
>>
>> cpu_cooling.c (CONFIG_CPU_THERMAL) uses cpu frequency table
>> intefaces so it should select CPU_FREQ_TABLE.
>> Fixes these build errors:
>>
>> drivers/built-in.o: In function `cpufreq_get_max_state':
>> cpu_cooling.c:(.text+0x4e1297): undefined reference to `cpufreq_frequency_get_table'
>> drivers/built-in.o: In function `cpufreq_set_cur_state':
>> cpu_cooling.c:(.text+0x4e138b): undefined reference to `cpufreq_frequency_get_table'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
>> Cc: Amit Daniel <amit.kachhap@...aro.org>

Feel free to add:

      Tested-by: Sedat Dilek <sedat.dilek@...il.com>

>> ---
>>  drivers/thermal/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> Also, please add info in the MAINTAINERS file for drivers/thermal/.
>>
>> --- linux-next-20120912.orig/drivers/thermal/Kconfig
>> +++ linux-next-20120912/drivers/thermal/Kconfig
>> @@ -22,6 +22,7 @@ config THERMAL_HWMON
>>  config CPU_THERMAL
>>         bool "generic cpu cooling support"
>>         depends on THERMAL && CPU_FREQ
>> +       select CPU_FREQ_TABLE
>
> This change looks good to me. Even similar select is present platform
> cpufreq drivers which uses the cpufreq API's.
>
> Thanks,
> Amit Daniel
>>         help
>>           This implements the generic cpu cooling mechanism through frequency
>>           reduction, cpu hotplug and any other ways of reducing temperature. An
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/