linux-kernel - Re: [PATCH 1/3] perf tool: precise mode requires exclude

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120913091303.GC8285@erda.amd.com>
Date:	Thu, 13 Sep 2012 11:13:03 +0200
From:	Robert Richter <robert.richter@....com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
CC:	David Ahern <dsahern@...il.com>, <linux-kernel@...r.kernel.org>,
	<peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>,
	Gleb Natapov <gleb@...hat.com>, Avi Kivity <avi@...hat.com>
Subject: Re: [PATCH 1/3] perf tool: precise mode requires exclude_guest

On 12.09.12 11:50:57, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 12, 2012 at 07:46:55PM +0200, Robert Richter escreveu:
> > On 12.09.12 09:16:28, David Ahern wrote:
> > > 
> > > Kernel side AMD currently ignores all exclude_* bits, so there is no impact
> > > to existing IBS code paths. Robert Richter has a patch where IBS code will
> > > return EINVAL if an exclude_* bit is set. When this goes in it means use
> > > of :p on AMD with IBS will first fail with EINVAL (because exclude_guest
> > > will be set). Then the existing fallback code within perf will unset
> > > exclude_guest and try again. The second attempt will succeed if the CPU
> > > supports IBS profiling.
> > > 
> > > Signed-off-by: David Ahern <dsahern@...il.com>
> > > Cc: Ingo Molnar <mingo@...nel.org>
> > > Cc: Peter Zijlstra <peterz@...radead.org>
> > > Cc: Robert Richter <robert.richter@....com>
> > > Cc: Gleb Natapov <gleb@...hat.com>
> > > Cc: Avi Kivity <avi@...hat.com>
> > > Link: https://lkml.org/lkml/2012/7/9/264
> > > ---
> > >  tools/perf/util/parse-events.c |    3 +++
> > >  1 file changed, 3 insertions(+)
> > 
> > Acked-by: Robert Richter <robert.richter@....com>
> > 
> > I tested the patch set with AMD IBS and it works fine.
> 
> Ok, I think that in this specific patchset I can add:
> 
> Tested-by: Robert Richter <robert.richter@....com>
> Reviewed-by: Robert Richter <robert.richter@....com>
> 
> Instead of an Acked-by, may I?

I am fine with this.

Thanks,

-Robert

> 
> - Arnaldo
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/