linux-kernel - Re: [PATCH] perf record: Add missing perf_hpp_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120913094826.GD8285@erda.amd.com>
Date:	Thu, 13 Sep 2012 11:48:26 +0200
From:	Robert Richter <robert.richter@....com>
To:	Namhyung Kim <namhyung@...nel.org>
CC:	Arnaldo Carvalho de Melo <acme@...hat.com>, <mingo@...nel.org>,
	<hpa@...or.com>, <paulus@...ba.org>,
	<linux-kernel@...r.kernel.org>, <a.p.zijlstra@...llo.nl>,
	<namhyung.kim@....com>, <tglx@...utronix.de>,
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [PATCH] perf record: Add missing perf_hpp__init for pipe-mode

On 13.09.12 13:14:30, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@....com>
> 
> The perf_hpp__init() function was only called from setup_browser() so
> that the pipe-mode missed the initialization thus didn't respond to
> related options.  Fix it.
> 
> Reported-by: Robert Richter <robert.richter@....com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/builtin-report.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

This patch fixes it.

Thanks,

-Robert

> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 97b2e6300f4c..279155a47d1c 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -689,8 +689,10 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
>  
>  	if (strcmp(report.input_name, "-") != 0)
>  		setup_browser(true);
> -	else
> +	else {
>  		use_browser = 0;
> +		perf_hpp__init(false, false);
> +	}
>  
>  	/*
>  	 * Only in the newt browser we are doing integrated annotation,
> -- 
> 1.7.11.4
> 
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/