linux-kernel - Re: [PATCH 3/5] staging: ipack: remove irq field in struct ipack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1347532384.4539.218.camel@fourier.local.igalia.com>
Date:	Thu, 13 Sep 2012 12:33:04 +0200
From:	Samuel Iglesias Gonsálvez 
	<siglesias@...lia.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Jens Taprogge <jens.taprogge@...rogge.org>,
	linux-kernel@...r.kernel.org,
	industrypack-devel@...ts.sourceforge.net
Subject: Re: [PATCH 3/5] staging: ipack: remove irq field in struct
 ipack_device.

On Thu, 2012-09-13 at 13:01 +0300, Dan Carpenter wrote:
> On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote:
> > From: Jens Taprogge <jens.taprogge@...rogge.org>
> > 
> > The field irq currently is identical to the slot number.  It does not seem to
> > have any real use.  The number is written to hardware in ipoctal but it seems
> > the value that is written does not matter.
> > 
> > Signed-off-by: Jens Taprogge <jens.taprogge@...rogge.org>
> > Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@...lia.com>
> > ---
> > -	iowrite8(vector, ipoctal->dev->mem_space.address + 1);
> > +	iowrite8(1, ipoctal->dev->mem_space.address + 1);
> 
> It might be nice to put a /* dummy write */ comment here.
> 

Added! Thanks for the suggestion,

Sam


Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)