linux-kernel - Re: [PATCH 4/9] drivers/hwmon/asus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120913134603.GB1400@roeck-us.net>
Date:	Thu, 13 Sep 2012 06:46:03 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Peter Senna Tschudin <peter.senna@...il.com>,
	Luca Tettamanti <kronos.it@...il.com>,
	kernel-janitors@...r.kernel.org, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] drivers/hwmon/asus_atk0110.c: Remove useless kfree

On Thu, Sep 13, 2012 at 09:05:06AM +0200, Jean Delvare wrote:
> On Wed, 12 Sep 2012 09:19:25 -0700, Guenter Roeck wrote:
> > On Wed, Sep 12, 2012 at 05:06:42PM +0200, Peter Senna Tschudin wrote:
> > > From: Peter Senna Tschudin <peter.senna@...il.com>
> > > 
> > > Remove useless kfree() and clean up code related to the removal.
> > 
> > Queued for -next.
> 
> Patch looks good, but I don't see any "code clean-up". Either it was
> intended but forgotten, or the patch description claims too much.
> 
Thought that referred to the kfree. You are right, that isn't really a cleanup.
I'll drop that comment.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/