linux-kernel - Re: [PATCH 1/2] coredump: pass siginfo_t* to do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120913150826.GA32128@redhat.com>
Date:	Thu, 13 Sep 2012 17:08:26 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Denys Vlasenko <vda.linux@...glemail.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Amerigo Wang <amwang@...hat.com>,
	Roland McGrath <roland@...k.frob.com>
Subject: Re: [PATCH 1/2] coredump: pass siginfo_t* to do_coredump() and
	below, not merely signr

On 09/13, Denys Vlasenko wrote:
>
> This is a preparatory patch for the introduction of NT_SIGINFO elf note.

I think the changelog should explain what the patch does.

With this patch we pass "siginfo_t *info" instead of "int signr" to
do_coredump() and put it into coredump_params, this "info" will be used
by the next patch. Other changes are simple s/signr/info->si_signo/.

> @@ -524,7 +524,7 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs)
>  	 */
>  	clear_thread_flag(TIF_SIGPENDING);
>  
> -	ispipe = format_corename(&cn, signr);
> +	ispipe = format_corename(&cn, info->si_signo);

Well, this conflicts with another fix which we discussed privately,
perhaps it would be better to push that simple change first...
But OK, this conflict is trivial.

Reviewed-by: Oleg Nesterov <oleg@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/