linux-kernel - Re: [PATCH 1/2] Staging: Comedi: dyna_pci10xx: Replace printk with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 13 Sep 2012 18:27:17 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Bruce Humphrey <brucehum@...il.com>
Cc:	abbotti@....co.uk, fmhess@...rs.sourceforge.net,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Staging: Comedi: dyna_pci10xx: Replace printk with
 dev_info

On Thu, Sep 13, 2012 at 04:46:02PM +0200, Bruce Humphrey wrote:
> Thanks for all the comments!
> 
> My own answers are from the complete linux kernel newbie point of view!
> That's why I'm writing them even if they seem obvious, to make sure.
> 
>  >               data[n] = 0;
> > > -             printk(KERN_DEBUG "comedi: dyna_pci10xx: "
> > > -                     "timeout reading analog input\n");
> > > +             dev_dbg(dev->class_dev, "timeout reading analog input\n");
> >
> > The trick with removing the "comedi: dyna_pci10xx: " prefix is that
> > you need to put this at the top of the file before the includes.
> >
> > #define pr_fmt(fmt) "comedi: dyna_pci10xx: " fmt
> >
> > You would need to remove the prefix from the other pr_info printk
> > as well so it's not included twice.
> >
> 
> Thanks for the very useful info!
> This would use pr_info, and not dev_info, which I think is prefered. But of
> course, pr_info is much better than printk, coding style wise.
> 

Sorry, for some reason I thought there was an existing pr_info() in
the file which would have needed to be updated.  I'm not sure what
I was looking at...

Anyway, this file has changed recently in linux-next so there is
only one printk() left now.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/