linux-kernel - Re: [PATCH 2/2] checksyscalls: ignore kcmp system call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Sep 2012 20:38:48 +0400
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Michal Marek <mmarek@...e.cz>,
	"H. Peter Anvin" <hpa@...ux.intel.com>
Subject: Re: [PATCH 2/2] checksyscalls: ignore kcmp system call

On Thu, Sep 13, 2012 at 06:02:37PM +0200, Heiko Carstens wrote:
> On Fri, Sep 07, 2012 at 04:02:34PM +0400, Cyrill Gorcunov wrote:
> > On Fri, Sep 07, 2012 at 01:31:31PM +0200, Heiko Carstens wrote:
> > > Now that the checksyscalls script works again it will warn about the missing
> > > "kcmp" system call on all architectures but x86.
> > > Since according to git commit d97b46a6 "syscalls, x86: add __NR_kcmp syscall"
> > > only x86 is currently supported don't emit any warning for this system call.
> [...]
> > > diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
> > > index fd8fa9a..c7cda79 100755
> > > --- a/scripts/checksyscalls.sh
> > > +++ b/scripts/checksyscalls.sh
> > > @@ -194,6 +194,9 @@ cat << EOF
> > >  #define __IGNORE_getpmsg
> > >  #define __IGNORE_putpmsg
> > >  #define __IGNORE_vserver
> > > +
> > > +/* kcmp is currently x86 only */
> > > +#define __IGNORE_kcmp
> 
> Ok, I wired the system call up on s390 and the test case passed.
> Below is the patch that is needed to actually reach the system call from
> other architectures than x86.
> Andrew, can you pick this one up as well?
> 
> The code that wires the system call up on s390 will go upstream via the
> s390 tree. Thanks to kcmp being a cond_syscall there is no compile
> time dependency.
> 
> From 1ff800597ea8f678a179387e3cf2ae663531e2fe Mon Sep 17 00:00:00 2001
> From: Heiko Carstens <heiko.carstens@...ibm.com>
> Date: Thu, 13 Sep 2012 09:37:38 +0200
> Subject: [PATCH] syscalls: make kcmp syscall available for all architectures
> 
> Remove the x86 dependency, since the system call is not
> architecture dependend.
> 
> Also add a ptrace.h include, so it compiles at least also on s390.
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
Reviewed-by: Cyrill Gorcunov <gorcunov@...nvz.org>

Thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/