linux-kernel - Re: [PATCH 07/24] Staging: ipack/devices/ipoctal: Store isr masks in ipoctal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120913174312.GB4587@mwanda>
Date:	Thu, 13 Sep 2012 20:43:12 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Samuel Iglesias Gonsalvez <siglesias@...lia.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Jens Taprogge <jens.taprogge@...rogge.org>,
	linux-kernel@...r.kernel.org,
	industrypack-devel@...ts.sourceforge.net
Subject: Re: [PATCH 07/24] Staging: ipack/devices/ipoctal: Store isr masks in
 ipoctal_channel

On Wed, Sep 12, 2012 at 02:55:29PM +0200, Samuel Iglesias Gonsalvez wrote:
> From: Jens Taprogge <jens.taprogge@...rogge.org>
> 
> This way interrupt handling becomes independent of the channel number.
> 
> Signed-off-by: Jens Taprogge <jens.taprogge@...rogge.org>
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@...lia.com>
> ---
> @@ -213,7 +206,7 @@ static int ipoctal_irq_handler(void *arg)
>  		}
>  
>  		/* RX data */
> -		if (isr_rx_rdy && (sr & SR_RX_READY)) {
> +		if ((isr && channel->isr_rx_rdy_mask) && (sr & SR_RX_READY)) {
                         ^^
Bitwise AND intended here I think.

>  			value = ioread8(&channel->regs->r.rhr);
>  			flag = TTY_NORMAL;
>  
> @@ -244,7 +237,7 @@ static int ipoctal_irq_handler(void *arg)
>  		}
>  
>  		/* TX of each character */
> -		if (isr_tx_rdy && (sr & SR_TX_READY)) {
> +		if ((isr & channel->isr_tx_rdy_mask) && (sr & SR_TX_READY)) {


regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/