linux-kernel - Re: [PATCH 14/19] ARM: ux500: Apply tc3589x's GPIO/IRQ properties to HREF's DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Sep 2012 09:33:48 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	STEricsson_nomadik_linux@...t.st.com, linus.walleij@...ricsson.com,
	arnd@...db.de
Subject: Re: [PATCH 14/19] ARM: ux500: Apply tc3589x's GPIO/IRQ properties to
 HREF's DT

On Mon, Sep 10, 2012 at 05:58:41AM -0700, Linus Walleij wrote:
> On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@...aro.org> wrote:
> 
> > This patch ensures the tc3589x and tc3598x-gpio devices are
> > rightfully given interrupt controller status. We also describe
> > the tc3598x-gpio GPIO expander in full and specify it as a GPIO
> > controller. Finally we reference that the external MMC slot's
> > Card Detection GPIO on the HREF is located on the tc3598x-gpio
> > expander.
> >
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> 
> This should come after the enablement patches instead of
> before them, right? (Or be merged into them even as
> we've discussed.)

No, it needs to come before, or else the legacy values will
be used which aren't correct.

> Apart from that it looks good,
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Yours,
> Linus Walleij

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/