linux-kernel - Re: [PATCH] usb: gadget: lpc32xx_udc: Disable setup request error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50530064.7020306@antcom.de>
Date:	Fri, 14 Sep 2012 12:01:08 +0200
From:	Roland Stigge <stigge@...com.de>
To:	Alexandre Pereira da Silva <aletes.xgr@...il.com>
CC:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: lpc32xx_udc: Disable setup request error
 message

On 12/09/12 22:33, Alexandre Pereira da Silva wrote:
> This message is an debugging message. It's useful for finding protocol
> details but it's not necessarily an error.
> 
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@...il.com>

Acked-by: Roland Stigge <stigge@...com.de>

Yes, the Kevin Wells at NXP confirmed this some time ago. Thanks!

> ---
>  drivers/usb/gadget/lpc32xx_udc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
> index 21a9861..d1cf1f4 100644
> --- a/drivers/usb/gadget/lpc32xx_udc.c
> +++ b/drivers/usb/gadget/lpc32xx_udc.c
> @@ -2399,7 +2399,7 @@ static void udc_handle_ep0_setup(struct lpc32xx_udc *udc)
>  
>  		if (i < 0) {
>  			/* setup processing failed, force stall */
> -			dev_err(udc->dev,
> +			dev_dbg(udc->dev,
>  				"req %02x.%02x protocol STALL; stat %d\n",
>  				reqtype, req, i);
>  			udc->ep0state = WAIT_FOR_SETUP;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/