linux-kernel - Re: [PATCH 1/1] pinctrl: Samsung: Fix return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbA8Uiy2ed5DJ99Aoztp=VOSL_2t9VGNi2bC3264LE7Hg@mail.gmail.com>
Date:	Fri, 14 Sep 2012 16:07:54 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>,
	Thomas Abraham <thomas.ab@...sung.com>
Cc:	linux-kernel@...r.kernel.org, patches@...aro.org
Subject: Re: [PATCH 1/1] pinctrl: Samsung: Fix return value

On Fri, Sep 14, 2012 at 2:02 PM, Sachin Kamat <sachin.kamat@...aro.org> wrote:

> Return the value obtained from of_property_count_strings()
> instead of -EINVAL.
>
> Silences the following smatch warning:
> drivers/pinctrl/pinctrl-samsung.c:529 samsung_pinctrl_parse_dt_pins()
> info: why not propagate '*npins' from of_property_count_strings()
> instead of -22?
>
> Cc: Thomas Abraham <thomas.ab@...sung.com>
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> ---
>  drivers/pinctrl/pinctrl-samsung.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c
> index 8a24223..824fda9 100644
> --- a/drivers/pinctrl/pinctrl-samsung.c
> +++ b/drivers/pinctrl/pinctrl-samsung.c
> @@ -526,7 +526,7 @@ static int __init samsung_pinctrl_parse_dt_pins(struct platform_device *pdev,
>         *npins = of_property_count_strings(cfg_np, "samsung,pins");
>         if (*npins < 0) {
>                 dev_err(dev, "invalid pin list in %s node", cfg_np->name);
> -               return -EINVAL;
> +               return *npins;
>         }

Thomas, please check this ...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/