linux-kernel - Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPV97ye-nW3oRtbDeVTAKaeTcHK2iyr8AuzEWmizRsD83fba7g@mail.gmail.com>
Date:	Fri, 14 Sep 2012 19:59:06 +0530
From:	navin patidar <navinp@...c.in>
To:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>,
	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	gregkh@...uxfoundation.org, mfm@...eddisk.com,
	linux-usb@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

hi,

I have sent this patch again with corrections.
thank for reviewing the patch.

--navin-patidar

On 9/14/12, Sebastian Andrzej Siewior <sebastian@...akpoint.cc> wrote:
> On Fri, Sep 14, 2012 at 03:42:42PM +0400, Sergei Shtylyov wrote:
>> >diff --git a/drivers/staging/usbip/stub_dev.c
>> > b/drivers/staging/usbip/stub_dev.c
>> >index 92ced35..f584af8 100644
>> >--- a/drivers/staging/usbip/stub_dev.c
>> >+++ b/drivers/staging/usbip/stub_dev.c
>> >@@ -233,6 +230,13 @@ static void stub_device_reset(struct usbip_device
>> > *ud)
>> >
>> >  	dev_dbg(&udev->dev, "device reset");
>> >
>> >+	/*reset tcp socket*/
>>
>>    Add spaces after /* and before */, please.
>>
>> >+	ud->tcp_socket = NULL;
>> >+
>> >+	/*reset kernel thread pointers */
>>
>>    Here too.
>
> I'm not sure it is required to comment the obvious things.
>
>> WBR, Sergei
>
> Sebastian
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/