linux-kernel - Re: [PATCH] cgroup: net_cls: Include missing header with sock_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5053442A.7040801@monom.org>
Date:	Fri, 14 Sep 2012 16:50:18 +0200
From:	Daniel Wagner <wagi@...om.org>
To:	sedat.dilek@...il.com
CC:	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	Daniel Wagner <daniel.wagner@...-carit.de>,
	"David S. Miller" <davem@...emloft.net>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Gao feng <gaofeng@...fujitsu.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Joe Perches <joe@...ches.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	Li Zefan <lizefan@...wei.com>,
	Neil Horman <nhorman@...driver.com>,
	Rick Jones <rick.jones2@...com>,
	Stanislav Kinsbursky <skinsbursky@...allels.com>,
	Tejun Heo <tj@...nel.org>, netdev@...r.kernel.org,
	cgroups@...r.kernel.org, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] cgroup: net_cls: Include missing header with sock_update_classid()
 definition

Hi Sedat,

On 14.09.2012 16:43, Sedat Dilek wrote:
> On Fri, Sep 14, 2012 at 4:33 PM, Daniel Wagner <wagi@...om.org> wrote:
>> From: Daniel Wagner <daniel.wagner@...-carit.de>
>>
>> commit 1f66c0a8833c3974ab6b35edcf4f8585b2f94592
>> Author: Daniel Wagner <daniel.wagner@...-carit.de>
>> Date:   Wed Sep 12 16:12:01 2012 +0200
>>
>>      cgroup: net_cls: Move sock_update_classid() declaration to cls_cgroup.h
>>
>> Claimed that there was only net/socket.c depending on
>> sock_update_class(). That is not true drivers/net/tun.c needs to
>> include the cls_cgroup.h header too.
>>
>> Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: "Michael S. Tsirkin" <mst@...hat.com>
>> Cc: Gao feng <gaofeng@...fujitsu.com>
>> Cc: Jamal Hadi Salim <jhs@...atatu.com>
>> Cc: Joe Perches <joe@...ches.com>
>> Cc: John Fastabend <john.r.fastabend@...el.com>
>> Cc: Li Zefan <lizefan@...wei.com>
>> Cc: Neil Horman <nhorman@...driver.com>
>> Cc: Rick Jones <rick.jones2@...com>
>> Cc: Stanislav Kinsbursky <skinsbursky@...allels.com>
>> Cc: Tejun Heo <tj@...nel.org>
>> Cc: netdev@...r.kernel.org
>> Cc: cgroups@...r.kernel.org
>> ---
>>
>> This version is on top of the latest cgroup for-3.7 branch.
>>
>
> Thanks for the quick fix.

No problem. I am still ashamed not finding it myself.

> Please honour Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>.

Sure, will do next time.

> If this is the fix for the breakage in today's Linux-Next
> (next-20120914), please add a "-next" to the subject next time.

Correct, this one is for linux-next but I got the impression that cgroup 
for-3.7 branch was ignored because of this. Therefore I have send two 
versions. Hmm, I'll need to check the results of todays next tree.

thanks,
daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/