linux-kernel - Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120914182137.GD18672@digium.com>
Date:	Fri, 14 Sep 2012 13:21:37 -0500
From:	Shaun Ruffell <sruffell@...ium.com>
To:	Shaohui Xie <Shaohui.Xie@...escale.com>
Cc:	linux-edac@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	akpm@...ux-foundation.org, avorontsov@...sta.com,
	linux-kernel@...r.kernel.org, grant.likely@...retlab.ca
Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe

On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote:
> Error handle in case of DDR ECC off is wrong, sysfs entries have not been
> created, so edac_mc_free which frees a mci instance should not be called.
> Also, free mci's memory in this case.

Jus FYI: I ran into the same error in edac_mc_free() which I
resolved in a slightly different way in some patches I sent
previously. [1]

[1] https://lkml.org/lkml/2012/9/14/475 

Cheers,
Shaun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/