[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120914190538.GN15728@agk-dp.fab.redhat.com>
Date: Fri, 14 Sep 2012 20:05:38 +0100
From: Alasdair G Kergon <agk@...hat.com>
To: Kent Overstreet <koverstreet@...gle.com>
Cc: linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org,
dm-devel@...hat.com, axboe@...nel.dk,
Alasdair Kergon <agk@...hat.com>
Subject: Re: [dm-devel] [PATCH v10 3/8] dm: Use bioset's front_pad for
dm_rq_clone_bio_info
On Fri, Sep 07, 2012 at 01:44:01PM -0700, Kent Overstreet wrote:
> Previously, dm_rq_clone_bio_info needed to be freed by the bio's
> destructor to avoid a memory leak in the blk_rq_prep_clone() error path.
> This gets rid of a memory allocation and means we can kill
> dm_rq_bio_destructor.
>
> The _rq_bio_info_cache kmem cache is unused now and needs to be deleted,
> but due to the way io_pool is used and overloaded this looks not quite
> trivial so I'm leaving it for a later patch.
Acked-by: Alasdair Kergon <agk@...hat.com>
> +/*
> + * Unused now, and needs to be deleted. But since io_pool is overloaded and it's
> + * still used for _io_cache, I'm leaving this for a later cleanup
> + */
Please avoid "I" in a source file unless you are the author of the file or
put your name after your comments.
An unattributed "FIXME" style of comment here would be fine.
Alasdair
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists