linux-kernel - Re: [PATCH] ACPI: Enable SCI_EMULATE to manually simulate physical hotplug testing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1347582132.3569.13.camel@misato.fc.hp.com>
Date:	Thu, 13 Sep 2012 18:22:12 -0600
From:	Toshi Kani <toshi.kani@...com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ashok Raj <ashok.raj@...el.com>
Subject: Re: [PATCH] ACPI: Enable SCI_EMULATE to manually simulate physical
 hotplug testing.

> > >> +
> > >> +     /*
> > >> +      * Check for internal object and make sure there is a handler
> > >> +      * registered for this object
> > >> +      */
> > >> +     obj_desc = acpi_ns_get_attached_object(node);
> > >> +     if (obj_desc) {
> > >> +             if (obj_desc->common_notify.notify_list[0]) {
> > >
> > > Is the above check necessary?  acpi_ev_queue_notify_request() sets up to
> > > call the global handler, acpi_gbl_global_notify[0], even if the object
> > > does not have a local handler registered.
> > 
> > Not sure.
> > 
> > maybe Len or other acpi guyes could answer your questions.
> 
> I think this check should be removed, but would like someone to
> verify...


Hi Yinghai,

Attached is my suggested update to your patch. It allows a SCI to be
sent to any object, and therefore can be used for testing the global
notify handler. Some drivers such as dock.c only register their handler
to the global notify handler. I also made a few minor changes. I have
been testing with this update and it is working fine. I like this
feature, so I hope we can make progress with this update.

Thanks,
-Toshi

View attachment "0001-ACPI-Update-CONFIG_ACPI_SCI_EMULATE-patch.patch" of type "text/x-patch" (2591 bytes)