linux-kernel - Re: [PATCH 2/2] xattr: prevent NULL ptr deref warnings in __simple_xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120914205849.GS19694@redhat.com>
Date:	Fri, 14 Sep 2012 16:58:49 -0400
From:	Aristeu Rozanski <aris@...hat.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Sasha Levin <levinsasha928@...il.com>, dan.carpenter@...cle.com,
	fengguang.wu@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] xattr: prevent NULL ptr deref warnings in
 __simple_xattr_set

On Fri, Sep 14, 2012 at 01:55:55PM -0700, Tejun Heo wrote:
> On Fri, Sep 14, 2012 at 01:54:34PM -0700, Tejun Heo wrote:
> > On Fri, Sep 14, 2012 at 09:35:54PM +0200, Sasha Levin wrote:
> > > Prevent warnings generated by smatch due to unchecked dereference of
> > > 'new_xattr' in __simple_xattr_set().
> > 
> > Isn't this an actual bug w/ or w/o smatch?  Remove request (NULL
> > @value) w/o XATTR_REPLACE for an non-existent node would end up
> > calling list_add() on NULL, right?  If so, please collapse these two
> > patches and mention the actual bug instead of smatch warning.
> 
> And can somebody please make that function less confusing? -
> restructuring / commenting whatever.  It's doing something simple.
> It's not supposed to be this confusing.

I'll work on that.

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/