[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120915152512.GB3037@amt.cnet>
Date: Sat, 15 Sep 2012 12:25:12 -0300
From: Marcelo Tosatti <mtosatti@...hat.com>
To: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
Cc: Avi Kivity <avi@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v2 4/5] KVM: MMU: introduce page_fault_start and
page_fault_end
On Fri, Sep 14, 2012 at 05:59:06PM +0800, Xiao Guangrong wrote:
> Wrap the common operations into these two functions
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
Why? I think people are used to
spin_lock(lock)
sequence
spin_unlock(lock)
So its easy to verify whether access to data structures are protected.
Unrelated to this patch, one opportunity i see to simplify this
code is:
- error pfn / mmio pfn / invalid pfn relation
Have the meaning of this bits unified in a single function/helper, see
comment to patch 1 (perhaps you can further improve).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists