linux-kernel - Re: [PATCH v2 3/9] PCI: preserve dev->subordinate until pci_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQU66sW4HsDuqh69evvcT0cfx61=6JtgrU7FTJjMo-_Njw@mail.gmail.com>
Date:	Fri, 14 Sep 2012 22:09:37 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Jiang Liu <liuj97@...il.com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Tony Luck <tony.luck@...el.com>,
	Yijing Wang <wangyijing@...wei.com>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	Jiang Liu <jiang.liu@...wei.com>
Subject: Re: [PATCH v2 3/9] PCI: preserve dev->subordinate until
 pci_stop_dev() has been called

On Fri, Sep 14, 2012 at 8:05 PM, Jiang Liu <liuj97@...il.com> wrote:
> From: Yijing Wang <wangyijing@...wei.com>
>
> Changeset 2ed168eeb3edec029aa0eca5cb981d6376f931f9 "PCI: Fold stop and
> remove helpers into their callers" has changed the behavior when
> removing a PCI device.
>
> Previously, for a PCI bridge device with secondary bus, dev->subordinate
> is valid when calling PCI bus notification callbacks for
> BUS_NOTIFY_ADD_DEVICE/BUS_NOTIFY_DEL_DEVICE events. Now dev->subordinate
> has been reset to NULL when calling callbacks for BUS_NOTIFY_DEL_DEVICE
> events, which may break some PCI bus notification callbacks.
>
> So revert to the original behavior to keep dev->subordinate valid for
> both BUS_NOTIFY_ADD_DEVICE events and BUS_NOTIFY_DEL_DEVICE events.
>
> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
> Signed-off-by: Jiang Liu <jiang.liu@...wei.com>
> ---
>  drivers/pci/remove.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
> index 86a4636..6244956 100644
> --- a/drivers/pci/remove.c
> +++ b/drivers/pci/remove.c
> @@ -79,16 +79,16 @@ void pci_stop_and_remove_bus_device(struct pci_dev *dev)
>          * iterator.  Therefore, iterate in reverse so we remove the VFs
>          * first, then the PF.
>          */
> -       if (bus) {
> +       if (bus)
>                 list_for_each_entry_safe_reverse(child, tmp,
>                                                  &bus->devices, bus_list)
>                         pci_stop_and_remove_bus_device(child);
> +       pci_stop_dev(dev);
>
> +       if (bus) {
>                 pci_remove_bus(bus);
>                 dev->subordinate = NULL;
>         }
> -
> -       pci_stop_dev(dev);
>         pci_destroy_dev(dev);
>  }
>  EXPORT_SYMBOL(pci_stop_and_remove_bus_device);

for support root bus support with acpi_pci_root (ioapic/iommu) will
need pci_stop_bus_devices()

so I just put those function back...

http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=commitdiff;h=247a40206cf44488f21bc6074cf0ba2805d4d840

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/