linux-kernel - Re: [PATCH] i2c/scx200_*: replace printks with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 14 Sep 2012 22:34:17 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jim Cromie <jim.cromie@...il.com>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c/scx200_*: replace printks with pr_<level>s

On Fri, 2012-09-14 at 21:21 -0600, Jim Cromie wrote:
> Replace printks with pr_<level>s, add pr_fmt()s to replace NAMEs

Hi Jim.

When you do these, please maximally fill to 80 columns the printk
arguments and coalesce formats without regard to 80 columns.

> diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
> @@ -406,7 +408,7 @@ static __devinit int scx200_acb_probe(struct scx200_acb_iface *iface)
>  
>  	val = inb(ACBCTL1);
>  	if (val) {
> -		pr_debug(NAME ": disabled, but ACBCTL1=0x%02x\n",
> +		pr_debug("disabled, but ACBCTL1=0x%02x\n",
>  			val);

		pr_debug("disabled, but ACBCTL1=0x%02x\n", val);

> @@ -417,7 +419,7 @@ static __devinit int scx200_acb_probe(struct scx200_acb_iface *iface)
>  
>  	val = inb(ACBCTL1);
>  	if ((val & ACBCTL1_NMINTE) != ACBCTL1_NMINTE) {
> -		pr_debug(NAME ": enabled, but NMINTE won't be set, "
> +		pr_debug("enabled, but NMINTE won't be set, "
>  			 "ACBCTL1=0x%02x\n", val);

		pr_debug("enabled, but NMINTE won't be set, ACBCTL1=0x%02x\n",
			  val);
etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/