lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 15 Sep 2012 10:28:09 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	"Kim, Milo" <Milo.Kim@...com>
CC:	Jonathan Cameron <jic23@....ac.uk>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] iio: inkern: allocate zeroed memory

On 09/14/2012 02:24 AM, Kim, Milo wrote:
>  Use kzalloc() rather than kmalloc() for initializing the iio_channel structure.
>  This patch enables the iio_dev and iio_chan_spec are set to NULL.
>  This may prevent the page fault problem because the pointer of iio_chan_spec
>  is initialized as NULL.
> 
>  The iio_chan_spec is updated only in case that the IIO map has
>  specific channel label.
>  When the map has no ADC channel label, then the value of iio_chan_spec
>  remains as invalid pointer.
>  To prevent this problem, the pointer should be initialized as NULL.
> 
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>
merged to togreg branch of iio.git


> ---
>  drivers/iio/inkern.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index b5afc2f..1faa240 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -130,7 +130,7 @@ struct iio_channel *iio_channel_get(const char *name, const char *channel_name)
>  	if (c == NULL)
>  		return ERR_PTR(-ENODEV);
>  
> -	channel = kmalloc(sizeof(*channel), GFP_KERNEL);
> +	channel = kzalloc(sizeof(*channel), GFP_KERNEL);
>  	if (channel == NULL)
>  		return ERR_PTR(-ENOMEM);
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists