linux-kernel - Re: [PATCH 2/2] Add 2-level GPUVM pagetables support to radeon driver. v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGZ4FESdyqFbMxJir=QdRURU1J-03NLOr+XT-TzqHFf+S=J8WQ@mail.gmail.com>
Date:	Sat, 15 Sep 2012 14:56:49 +0200
From:	Maarten Maathuis <madman2003@...il.com>
To:	Dmitry Cherkasov <dcherkassov@...il.com>
Cc:	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Alex Deucher <alexander.deucher@....com>,
	Dmitry Cherkasov <Dmitrii.Cherkasov@....com>
Subject: Re: [PATCH 2/2] Add 2-level GPUVM pagetables support to radeon
 driver. v2

On Fri, Sep 14, 2012 at 7:49 PM, Dmitry Cherkasov <dcherkassov@...il.com> wrote:
> +#define RADEON_PT_OFFSET(_rdev) \
> +       (RADEON_GPU_PAGE_ALIGN(RADEON_TOTAL_PDE_COUNT(rdev) * RADEON_PDE_SIZE))

Shouldn't that be _rdev too?

Also a few lines above that you use rdev instead of _rdev.

I didn't check the whole thing, just noticed that when i was staring
at it for no reason :-)

-- 
Far away from the primal instinct, the song seems to fade away, the
river get wider between your thoughts and the things we do and say.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/