[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120916143822.GA20312@redhat.com>
Date: Sun, 16 Sep 2012 16:38:22 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Cc: Ananth N Mavinakayanahalli <ananth@...ibm.com>,
Anton Arapov <anton@...hat.com>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] uprobes: Kill UTASK_BP_HIT state
On 09/14, Oleg Nesterov wrote:
>
> Kill UTASK_BP_HIT state, it buys nothing but complicates the code.
> It is only used in uprobe_notify_resume() to decide who should be
> called, we can check utask->active_uprobe != NULL instead. And this
> allows us to simplify handle_swbp(), no need to clear utask->state.
I am starting to think this patch makes even more sense than I thought.
> Likewise we could kill UTASK_SSTEP,
In fact we can kill utask->state. But I just realized we can also kill
uprobe_deny_signal() and simplify arch_uprobe_xol_was_trapped() logic.
But this needs some (simple) changes in arch/ code, so we need to wait
until powerpc is merged.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists