linux-kernel - Re: [PATCH v3] ACPI/pci-bind: remove bind/unbind callbacks from acpi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQU4tNDot3J9EEwhd=YUfTSoojtreb2JFVn-=KUsq=W+ow@mail.gmail.com>
Date:	Sun, 16 Sep 2012 11:02:45 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Jiang Liu <liuj97@...il.com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Jiang Liu <jiang.liu@...wei.com>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Yijing Wang <wangyijing@...wei.com>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v3] ACPI/pci-bind: remove bind/unbind callbacks from acpi_device_ops

On Sun, Sep 16, 2012 at 9:49 AM, Yinghai Lu <yinghai@...nel.org> wrote:
> On Sun, Sep 16, 2012 at 7:09 AM, Jiang Liu <liuj97@...il.com> wrote:
>> @@ -160,10 +160,13 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle)
>>         }
>>         dev->archdata.acpi_handle = handle;
>>
>> -       acpi_pci_bind_notify(dev->archdata.acpi_handle, dev, true);
>> -
>>         status = acpi_bus_get_device(handle, &acpi_dev);
>> -       if (!ACPI_FAILURE(status)) {
>> +       if (!ACPI_FAILURE(status))
>> +               acpi_dev = NULL;
>> +
>> +       acpi_pci_bind_notify(dev->archdata.acpi_handle, acpi_dev, dev, true);
>
> It seems you can do
>     acpi_pci_bind_notify(acpi_dev, dev, true);
> instead.
>
> aka:
> Do you have test case acpi_dev is not created before pci device?
>

updated your patch, and retrieve handle if needed from acpi_dev->handle or
pci_dev->dev.archdata.acpi_handle.

Thanks

Yinghai

Download attachment "jiang_hotplug_rework_5.patch" of type "application/octet-stream" (13030 bytes)