linux-kernel - Re: [PATCH] DMA: PL330: return ENOMEM instead of 0 from pl330_alloc_chan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABb+yY1-_NVHfGnRNpNpN1g8Xk399SRjippR_8DQ2pBYRxx47w@mail.gmail.com>
Date:	Mon, 17 Sep 2012 11:17:28 +0530
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Inderpal Singh <inderpal.singh@...aro.org>
Cc:	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	kgene.kim@...sung.com, vinod.koul@...el.com, patches@...aro.org,
	boojin.kim@...sung.com
Subject: Re: [PATCH] DMA: PL330: return ENOMEM instead of 0 from pl330_alloc_chan_resources

On Mon, Sep 17, 2012 at 9:57 AM, Inderpal Singh
<inderpal.singh@...aro.org> wrote:
> Since 0 is not considered as error at dmaengine level, return ENOMEM
> from pl330_alloc_chan_resources in case of failure.
>
> Signed-off-by: Inderpal Singh <inderpal.singh@...aro.org>

Acked-by: Jassi Brar <jassisinghbrar@...il.com>


> ---
>  drivers/dma/pl330.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index e4feba6..14d881c 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2393,7 +2393,7 @@ static int pl330_alloc_chan_resources(struct dma_chan *chan)
>         pch->pl330_chid = pl330_request_channel(&pdmac->pif);
>         if (!pch->pl330_chid) {
>                 spin_unlock_irqrestore(&pch->lock, flags);
> -               return 0;
> +               return -ENOMEM;
>         }
>
>         tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch);
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/