[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120917071642.GC13023@secunet.com>
Date: Mon, 17 Sep 2012 09:16:42 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Mathias Krause <minipli@...glemail.com>
Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] xfrm_user: return error pointer instead of NULL
On Thu, Sep 13, 2012 at 11:41:26PM +0200, Mathias Krause wrote:
> When dump_one_state() returns an error, e.g. because of a too small
> buffer to dump the whole xfrm state, xfrm_state_netlink() returns NULL
> instead of an error pointer. But its callers expect an error pointer
> and therefore continue to operate on a NULL skbuff.
>
> This could lead to a privilege escalation (execution of user code in
> kernel context) if the attacker has CAP_NET_ADMIN and is able to map
> address 0.
Or it simply crashes with a NULL pointer dereference.
>
> Cc: stable@...r.kernel.org
> Signed-off-by: Mathias Krause <minipli@...glemail.com>
Acked-by: Steffen Klassert <steffen.klassert@...unet.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists