linux-kernel - Re: [PATCH] i915: Quirk out disconnected backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a9wp84a5.fsf@intel.com>
Date:	Mon, 17 Sep 2012 11:03:30 +0300
From:	Jani Nikula <jani.nikula@...ux.intel.com>
To:	Grant Likely <grant.likely@...retlab.ca>,
	David Woodhouse <dwmw2@...radead.org>
Cc:	Daniel Vetter <daniel.vetter@...ll.ch>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Matthew Garrett <mjg@...hat.com>
Subject: Re: [PATCH] i915: Quirk out disconnected backlight

On Fri, 14 Sep 2012, Grant Likely <grant.likely@...retlab.ca> wrote:
> On Fri, Sep 14, 2012 at 2:12 PM, David Woodhouse <dwmw2@...radead.org> wrote:
>> See https://bugzilla.redhat.com/show_bug.cgi?id=752595
>
> In that bug you mention that the intel backlight sets a bogus max of
> '1' when a backlight isn't present. I saw that too here. Here's the
> offending code:
>
> u32 intel_panel_get_max_backlight(struct drm_device *dev)
> {
>         struct drm_i915_private *dev_priv = dev->dev_private;
>         u32 max;
>
>         max = i915_read_blc_pwm_ctl(dev_priv);
>         if (max == 0) {
>                 /* XXX add code here to query mode clock or hardware clock
>                  * and program max PWM appropriately.
>                  */
>                 pr_warn_once("fixme: max PWM is zero\n");
>                 return 1;
>         }
>
> I used a quirk in my patch, but I could instead change the driver to
> bail here instead of trying to limp along.

Hi Grant, please try v3.6-rc6 that does exactly that with:

commit 28dcc2d60cb570d9f549c329b2f51400553412a1
Author: Jani Nikula <jani.nikula@...el.com>
Date:   Mon Sep 3 16:25:12 2012 +0300

    drm/i915: do not expose a dysfunctional backlight interface to userspace

Does that fix it for you?


BR,
Jani.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/