linux-kernel - Re: [PATCH 0/6] media: input: convert to c99 format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201209171737.51989.hverkuil@xs4all.nl>
Date:	Mon, 17 Sep 2012 17:37:51 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Shubhrajyoti D <shubhrajyoti@...com>
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	julia.lawall@...6.fr
Subject: Re: [PATCH 0/6] media: input: convert to c99 format

On Mon September 17 2012 17:22:27 Shubhrajyoti D wrote:
> The series tries to convert the i2c_msg to c99 struct.
> This may avoid issues like below if someone tries to add an
> element to the structure.
> http://www.mail-archive.com/linux-i2c@vger.kernel.org/msg08972.html

I'm OK with this provided that these intializations are formatted with
one field per line. It's rather hard to read otherwise since the lines
are now a lot longer.

Regards,

	Hans

> Special thanks to Julia Lawall for helping it automate.
> By the below script.
> http://www.mail-archive.com/cocci@diku.dk/msg02753.html
> 
> Checkpatch warn of more than 80 chars have been ignored.
> 
> Shubhrajyoti D (6):
>   media: Convert struct i2c_msg initialization to C99 format
>   media: Convert struct i2c_msg initialization to C99 format
>   media: Convert struct i2c_msg initialization to C99 format
>   media: Convert struct i2c_msg initialization to C99 format
>   media: Convert struct i2c_msg initialization to C99 format
>   media: Convert struct i2c_msg initialization to C99 format
> 
>  drivers/media/i2c/ks0127.c                    |    4 ++--
>  drivers/media/i2c/msp3400-driver.c            |   12 ++++++------
>  drivers/media/i2c/tvaudio.c                   |    4 ++--
>  drivers/media/radio/radio-tea5764.c           |    6 +++---
>  drivers/media/radio/saa7706h.c                |    4 ++--
>  drivers/media/radio/si470x/radio-si470x-i2c.c |   12 ++++++------
>  6 files changed, 21 insertions(+), 21 deletions(-)
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/